Restore proper Jest assertion in event dispatch error handling test#7
Merged
igorls merged 2 commits intofeat/event-based-loggingfrom Dec 5, 2025
Merged
Restore proper Jest assertion in event dispatch error handling test#7igorls merged 2 commits intofeat/event-based-loggingfrom
igorls merged 2 commits intofeat/event-based-loggingfrom
Conversation
Co-authored-by: igorls <4753812+igorls@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP Address feedback on event-based system implementation
Restore proper Jest assertion in event dispatch error handling test
Dec 5, 2025
igorls
approved these changes
Dec 5, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a test that was inadvertently changed to always pass regardless of the actual behavior being tested. The test for dispatchEvent error handling in the onReconnectionFailed callback flow was using a try-catch block that silently swallowed all exceptions, making it impossible to detect if the error handling was working correctly.
Key Changes:
- Restored proper Jest assertion
expect(() => api.dispatchEvent(event)).not.toThrow()in the error handling test - Removed the try-catch wrapper that made the test unconditionally pass
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test for
dispatchEventerror handling was changed to use a try-catch block that ignores all exceptions, making the test always pass regardless of whether exceptions occur.Changes
expect(() => api.dispatchEvent(event)).not.toThrow()assertion intest/connection-state.spec.ts:238The test now properly validates that
dispatchEventhandles callback errors without throwing, rather than unconditionally passing.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.